[IMP] peek into the JWT to get the channel uuid#21
Open
ThanhDodeurOdoo wants to merge 1 commit intomasterfrom
Open
[IMP] peek into the JWT to get the channel uuid#21ThanhDodeurOdoo wants to merge 1 commit intomasterfrom
ThanhDodeurOdoo wants to merge 1 commit intomasterfrom
Conversation
ThanhDodeurOdoo
force-pushed
the
simple-channel-check-tso
branch
from
40e2cb6 to
2aab6d6
Compare
ThanhDodeurOdoo
added
the
backwards-compatible: new server + old client
ThanhDodeurOdoo
force-pushed
the
simple-channel-check-tso
branch
from
2aab6d6 to
76fb87f
Compare
Before this commit, the payload of the first websocket message (auth) would expect the channel uuid along the jwt, to know where to look to get the key used to sign it. It was slightly redundant as the channel uuid is part of the jwt payload. With the new JWT implementation, we now have the freedom to read the JWT before verifying it. It also reduces the business code complexity as we no longer need to check the corner case of passing a keyed channel uuid in the jwt while skipping the channelUUID of the websocket payload (see removed code in `connect()` of `ws.js`. This is safe to do as the payload is verified with the key of the channel, which means that the signature has to match the channel uuid and tampering with it would invalidate the content.
ThanhDodeurOdoo
force-pushed
the
simple-channel-check-tso
branch
from
76fb87f to
5d2b7a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the payload of the first websocket message (auth) would expect the channel uuid along the jwt, to know where to look to get the key used to sign it.
It was slightly redundant as the channel uuid is part of the jwt payload. With the new JWT implementation, we now have the freedom to read the JWT before verifying it.
It also reduces the business code complexity as we no longer need to check the corner case of passing a keyed channel uuid in the jwt while skipping the channelUUID of the websocket payload (see removed code in
connect()ofws.js.This is safe to do as the payload is verified with the key of the channel, which means that the signature has to match the channel uuid and tampering with it would invalidate the content.